fix(ntn): curricula date filtering #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start and end date checks for curricula incorrect filter out curricula that are starting or ending on the given day. Update the NtnGenerator to check date equality as well as before/after. TIS21-6175 TIS21-6182
The NTN should be calculated for future programme memberships, using the start date as a filter. i.e. the NTN will only consider curricula which start, or have somehow started, on the day the programme starts for that trainee. TIS21-6175 TIS21-6182
|
ReubenRobertsHEE
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ntn): include curricula starting/ending today
The start and end date checks for curricula incorrect filter out
curricula that are starting or ending on the given day.
Update the NtnGenerator to check date equality as well as before/after.
TIS21-6175
TIS21-6182
fix(ntn): calculate for future programmes
The NTN should be calculated for future programme memberships, using the
start date as a filter.
i.e. the NTN will only consider curricula which start, or have somehow
started, on the day the programme starts for that trainee.
TIS21-6175
TIS21-6182